Skip to content

Conversation

@FabienTregan
Copy link

This is preminilary work I did trying to see if I can re-open the PVH PR. I am quiet new to all of this.

@tylerfanelli
Copy link
Member

Can you add a Signed-off-by line to the commits?

Comment on lines 220 to 221
make BLK=1 NET=1
```

then

```
sudo make BLK=1 NET=1 install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make BLK=1 NET=1
```
then
```
sudo make BLK=1 NET=1 install
make BLK=1 NET=1
sudo make BLK=1 NET=1 install

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jakecorrenti
Copy link
Member

Hi @FabienTregan, just want to follow up and see if you need any help getting this to a merge-ready state.

@FabienTregan
Copy link
Author

Conference + job searching last week, I should be able to get back on libkrun tomorrow !

@FabienTregan FabienTregan force-pushed the chroot_vm_build_doc_update branch from fa8deec to a20c4d4 Compare November 28, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants